Decode by Mail gem's decoded before Kconving#95
Merged
Conversation
body is now decoded by the hybrid approach as follows: body.decoded: handles Content-Transfer-Encoding (base64, quoted-printable) Kconv.toutf8: auto-detects charset (handles mislabeled charsets in legacy emails)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
body is now decoded by the hybrid approach as follows: body.decoded: handles Content-Transfer-Encoding (base64, quoted-printable) Kconv.toutf8: auto-detects charset (handles mislabeled charsets in legacy emails).
This patch is a fix for mojibake in newly imported messages, and the mojibake in some existing messages in production DB are already updated by another batch that implements similar logic.