Skip to content

Strip complete version constraints without joining package names #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Strip complete version constraints without joining package names #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d99fe59
Strip complete version constraints without joining package names
OskarEichler Aug 28, 2026
91f7859
Add regression coverage for strip complete version constraints withou…
OskarEichler Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/pkg-config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,7 @@ def parse_pc

def parse_requires(requires)
return [] if requires.nil?
requires_without_version = requires.gsub(/(?:<|>|<=|>=|=)\s*[\d.a-zA-Z_-]+\s*/, "")
requires_without_version = requires.gsub(/(?:!=|<=|>=|<|>|=)\s*[^,\s]+\s*/, " ")
requires_without_version.split(/[,\s]+/)
end

Expand Down
5 changes: 5 additions & 0 deletions test/test-pkg-config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,11 @@ def test_equals_to
assert_equal(["fribidi"],
parse_requires("fribidi = 1.0"))
end

def test_multiple_requirements_with_compact_constraints
assert_equal(["foo", "bar", "baz"],
parse_requires("foo>=1.2 bar != 2.0, baz=3.0"))
end
end

sub_test_case("#merge_back_cflags") do
Expand Down