Keep the dash when joining separated linker flags - #50
Open
OskarEichler wants to merge 2 commits into
Open
OskarEichler wants to merge 2 commits into
OskarEichler wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve -L and -l when joining their separated arguments, including tab and repeated-space separators.
Reproduction and verification
For a .pc file with
Libs: -L /opt/lib -l foo,PackageConfig#libscurrently returnsL/opt/lib lfoo; both filtered libraries/path accessors are empty. The capture group drops the hyphen. Expected:-L/opt/lib -lfoo, with both accessors retaining their respective flags.Five splitter cases and three public-accessor checks were exercised; baseline fails the three separated forms and three public checks, candidate passes.
Existing suite on Ruby 4.0.6 through rbenv: 27 tests, 31 assertions, zero failures/errors, two upstream macOS omissions, baseline and this isolated patch. Combined installed-release consumer also passes the suite, 1,098 focused/model checks, four process cases, five linker-option cases and four path cases.
rbenv exec ruby test/run.rbruns the existing suite.Compatibility and limitations
Malformed output becomes usable flags. Already-joined flags are unchanged. This patch does not implement quoted paths or otherwise rewrite linker parsing.
No tests were added or modified under the consuming repository's no-new-tests policy. Verification uses existing tests and external scratch reproductions. No production changes; older Ruby/Linux/Windows matrices await upstream CI. No unrelated version/dependency changes.