pr fix tests before release#972
Merged
Merged
Conversation
* test/hyrolo-tests.el (hyrolo-tests--grep-or-fgrep): Use cl-letf for mocking call-interactively. Functions with optional arguments does not work with el-mock and native compilation. The mock is called with the optional args set to nil causing it to see different number of arguments depending on whether the code is natively compiled or not.
* test/hywiki-tests.el (hywiki-tests--edit-string-pairs): Uncomment working test case.
Cleanup: Possibly this once documented that the wrong ibtype was found and that got fixed without removing this comment!? * test/hbut-tests.el (hbut-tests--ibut-at-p-identifies-a-remote-pathname): Remove comment.
rswgnu
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Walk over notes in the test possibly uncovering tests that now
works. One working test found. A mock problem was spotted. Rest is
cleanup.