Skip to content

fix: refine nestjs example#473

Merged
intellild merged 2 commits into
mainfrom
nestjs_example_0611
Jun 11, 2026
Merged

fix: refine nestjs example#473
intellild merged 2 commits into
mainfrom
nestjs_example_0611

Conversation

@intellild

Copy link
Copy Markdown
Contributor

No description provided.

@intellild intellild linked an issue Jun 11, 2026 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: aab714bc-31ef-4793-a425-4213eefc9087

📥 Commits

Reviewing files that changed from the base of the PR and between 6726ced and 1742e69.

📒 Files selected for processing (5)
  • rspack/nestjs/package.json
  • rspack/nestjs/rspack.config.mjs
  • rspack/nestjs/src/main.ts
  • rspack/nestjs/tsconfig.build.json
  • rspack/nestjs/tsconfig.json

📝 Walkthrough

Walkthrough

This PR updates the Rspack/NestJS example project to modernize its development tooling and HMR integration. The dev script now uses cross-env to explicitly set NODE_ENV to development and runs rspack in watch mode. The Rspack configuration is refactored to derive a centralized isDev constant that controls both entry point selection and plugin configuration. The application's hot module replacement is migrated from CommonJS module.hot to ESM import.meta.webpackHot. TypeScript configuration files are added to define compiler options and build-specific exclusions.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a description explaining what was refined in the NestJS example and why these changes were necessary.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: refine nestjs example' is directly related to the changeset, which refines the NestJS example configuration and implementation files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nestjs_example_0611

Comment @coderabbitai help to get the list of available commands and usage tips.

@intellild intellild merged commit 2a57932 into main Jun 11, 2026
4 checks passed
@intellild intellild deleted the nestjs_example_0611 branch June 11, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nestjs example项目局域网地址关不掉

1 participant