Repository navigation
test(e2e): drive the plugin-host smoke test through the public API - #122
Merged
Merged
Conversation
`@rslint/core` 0.10.0 projects each file's ESTree frame in Go and ships it in the `rslint/pluginLint` request (`EslintPluginLintRequest.files[].frame` is now required). The smoke test hand-built a request with just a path, so the host threw `ERR_INVALID_ARG_TYPE` from `resolvePluginAttachments` and the 0.10.0 toolchain bump failed E2E on the first slice. Drive the pipeline through `Rslint#lintFiles` instead: Go produces the frames, and the project install's `eslint-plugin` entry answers the same reverse request, so the run still proves the packaged plugin path works from a plain project install. The test keeps asserting that both the package entry and `@rslint/core/eslint-plugin` resolve inside one resolution root and that the host entry loads. Verified against `@rslint/core` 0.9.5 and 0.10.0; the VS Code `eslintPlugins` and plugin-host-failure suites pass on 0.10.0.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@rslint/core0.10.0 moved ESTree projection into Go.rslint/pluginLintrequests now always carry a frame per file (EslintPluginLintRequest.files[].frameis required), so the smoke test's hand-builthost.lint({ files: [{ path, configKey }] })request is no longer valid — the host throwsERR_INVALID_ARG_TYPEinresolvePluginAttachments. That is the failure that currently blocks #112 (chore(deps): update rstack toolchain, which bumps@rslint/coreto 0.10.0) on the first E2E slice.The smoke test now drives the same pipeline through
Rslint#lintFiles: Go projects the frames and the project install'seslint-pluginentry answers the reversepluginLintrequest, so the run still proves the packaged plugin path works from a plain project install. It keeps asserting that the package entry and@rslint/core/eslint-pluginresolve inside one resolution root and that the host entry loads.Verified locally:
@rslint/core0.9.5 and 0.10.0lintE2E slice green on 0.10.0 (all 21 suites, includingeslintPluginsandPlugin-host failure)pnpm lintandpnpm test:unitgreen on 0.10.0Related Links
Checklist