Skip to content

chore: enable recommended import lint rules - #607

Merged
chenjiahan merged 1 commit into
mainfrom
codex/enable-import-plugin
Nov 2, 2026
Merged

chenjiahan merged 1 commit into
mainfrom
codex/enable-import-plugin

Conversation

@elecmonkey

Copy link
Copy Markdown
Member

Motivation

Enable Rslint's recommended import rules following the upgrade to 0.10.0.

Changes

  • Enable importPlugin.configs.recommended.
  • Disable import/no-unresolved for templates and type fixtures, whose dependencies or declaration-only assets are not available for resolution in this repository.
  • Use named imports for sortPackageJson and Tinypool to satisfy import/no-named-as-default. This rule warns when a default import uses the name of an existing named export, helping catch accidental confusion between the two. Both packages export the same function or class through both forms, so adding braces makes the intended named import explicit without changing behavior.
  • Add inline import/default suppressions for the two micromatch imports. These valid CommonJS default imports are incorrectly reported as missing a default export; the upstream fix is tracked in fix(import): handle merged export assignments and implicit interop web-infra-dev/rslint#2481.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying rstack-cli with  Cloudflare Pages  Cloudflare Pages

Latest commit: e229d5d
Status: ✅  Deploy successful!
Preview URL: https://92916961.rstack-cli.pages.dev
Branch Preview URL: https://codex-enable-import-plugin.rstack-cli.pages.dev

View logs

@chenjiahan chenjiahan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chenjiahan
chenjiahan merged commit 409e9a7 into main Nov 2, 2026
5 checks passed
@chenjiahan
chenjiahan deleted the codex/enable-import-plugin branch November 2, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants