fix(setup): reject parent hooks directories - #107
Conversation
Deploying rstack-cli with
|
| Latest commit: |
2c0fe6b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c442f1d6.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-fix-setup-hooks-d-mdt4.rstack-cli.pages.dev |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c0fe6b2e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
📝 WalkthroughWalkthroughThe setup installation flow now rejects normalized 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rs setup --hooks-dircurrently accepts parent directory paths, allowing generated Git hook files to be written outside the current project.This PR rejects paths containing
.., adds CLI regression coverage, and documents the restriction.