Skip to content

chore(ci): fix wasm package name#169

Open
stormslowly wants to merge 1 commit intomainfrom
fix/wasm_release_2
Open

chore(ci): fix wasm package name#169
stormslowly wants to merge 1 commit intomainfrom
fix/wasm_release_2

Conversation

@stormslowly
Copy link
Collaborator

@stormslowly stormslowly commented Mar 5, 2026

@rspack/resolver-binding-threads-wasm32 -> @rspack/resolver-binding-wasm32-wasi

Copilot AI review requested due to automatic review settings March 5, 2026 16:52
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue within the continuous integration (CI) pipeline by enhancing the script responsible for parsing target triples. The update introduces dedicated logic to accurately interpret WebAssembly (WASM) specific triples, which is essential for correct package naming and build processes in WASM environments. This ensures that WASM-related builds are handled consistently and without errors.

Highlights

  • WASM Triple Parsing: Modified the parseTriple function in scripts/prepublish.mjs to correctly identify and parse WebAssembly (WASM) target triples, specifically wasm32-wasi and its variations, ensuring proper platform, architecture, and ABI recognition.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • scripts/prepublish.mjs
    • Improved parsing logic for WebAssembly (WASM) target triples.
Activity
  • No specific activity (comments, reviews) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes the package name generation for WASM targets by adding special handling for WASM-related target triples in scripts/prepublish.mjs. The change correctly addresses the issue. I have provided one suggestion to simplify the implementation and make it more robust for future WASM target variations.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants