Conversation
|
This isn't my repo, so take this with a grain of salt, but if you're doing a PR into someone else's repo, then I would think the addon.setup.php file should retain the original author information. Perhaps in a comment you can add something like "Updated for EE version X by [name]" I would also suggest squashing this into a single commit so the merge is cleaner. I don't see the need having 14 separate commits in the timeline. |
Hi there Brian, I did mention the original author in addon.setup.php at the top of the code in the commented area. I'm not very Github-savvy. As can be seen by the number of commits. Whenever I thought the readme was finished , I came up with a change. Again, I apologize. By the way, it wasn't me that did the PR :) |
I'll try. There were some radical changes in the way EE6 handles custom fields in the database. |
|
do not merge the abovementioned commits. There are mistakes in them. They were made on upgraded versions of ExpressionEngine with legacy data and legacy database tables. I'm working on a versions created on fresh installs of EE4 (pretty much done, and should work on EE5 as well) and EE6. |
|
Try this: v3.0.0 JSON Output for EE6 |
|
Reworked code for EE4, EE5 and EE6 compatibility: v2.5.0 JSON Output for EE4, EE5 & EE6 |
Make support for EE6