Found by the round-3 strict review of #1153, in a test that PR's round 2 added.
cmd/abctl/cmd_cost_test.go, TestRunCost_ByCurrencyMatchesAUnitSpelledADifferentWay:
if strings.Contains(row, mixedCostCell) {
t.Errorf("a real configured unit was withheld as unrecognised:\n%s", row)
}The fixture carries "currencies":["Credits"] — one entry — so windowUnit returns labelled=true and writeCostBreakdown's default: cost = mixedCostCell arm is unreachable for a priced row. The assertion cannot fire on this input, and its stated reason ("withheld as unrecognised") describes a path the fixture does not reach.
The test's first assertion is live and does pin the property that matters (a unit spelled differently from the reported set keeps its label, i.e. isReportedUnit folds case). Only the negative twin is dead.
Fix is either a second fixture whose window is genuinely mixed, or dropping the assertion and saying in the comment that the single-unit fixture cannot produce (mixed). Prefer whichever keeps the test's one claim legible.
Assisted-By: Claude (Anthropic AI) noreply@anthropic.com
Found by the round-3 strict review of #1153, in a test that PR's round 2 added.
cmd/abctl/cmd_cost_test.go,TestRunCost_ByCurrencyMatchesAUnitSpelledADifferentWay:The fixture carries
"currencies":["Credits"]— one entry — sowindowUnitreturnslabelled=trueandwriteCostBreakdown'sdefault: cost = mixedCostCellarm is unreachable for a priced row. The assertion cannot fire on this input, and its stated reason ("withheld as unrecognised") describes a path the fixture does not reach.The test's first assertion is live and does pin the property that matters (a unit spelled differently from the reported set keeps its label, i.e.
isReportedUnitfolds case). Only the negative twin is dead.Fix is either a second fixture whose window is genuinely mixed, or dropping the assertion and saying in the comment that the single-unit fixture cannot produce
(mixed). Prefer whichever keeps the test's one claim legible.Assisted-By: Claude (Anthropic AI) noreply@anthropic.com