Skip to content

fix context in wait for message wait set #3030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahcorde merged 1 commit into from
Jan 22, 2026
Merged

fix context in wait for message wait set #3030

ahcorde merged 1 commit into from
Jan 22, 2026
+30 −1

Conversation

@rahatchd
Copy link
Contributor

@rahatchd rahatchd commented Jan 22, 2026

Description

fix DCO

see #3021

@rahatchd
fix context in wait for message wait set
4c01608 
Signed-off-by: Rahat Dhande <rahatchd@gmail.com>
@rahatchd rahatchd mentioned this pull request Jan 22, 2026
Merged
fujitatomoya
fujitatomoya approved these changes Jan 22, 2026
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! looks good to me including DCO.

btw, you can add signoff later with git commit --signoff --amend just FYI.

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Jan 22, 2026 •
edited by ahcorde
Loading

Pulls: #3030
Gist: https://gist.githubusercontent.com/fujitatomoya/06ac9ee6f538ff9268bf0e78f9f0fc85/raw/4111bac8eaa7ac73441941e5dd1055384a752f12/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18014

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit fcc505f into ros2:rolling Jan 22, 2026
2 of 3 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented Jan 22, 2026

https://github.com/Mergifyio backport kilted jazzy humble

@mergify
Copy link
Contributor

mergify bot commented Jan 22, 2026 •
edited
Loading

backport kilted jazzy humble

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jan 22, 2026
@rahatchd @mergify
fix context in wait for message wait set (#3030)
ba96abd 
Signed-off-by: Rahat Dhande <rahatchd@gmail.com>
(cherry picked from commit fcc505f)
@mergify mergify bot mentioned this pull request Jan 22, 2026
Merged
mergify bot pushed a commit that referenced this pull request Jan 22, 2026
@rahatchd @mergify
fix context in wait for message wait set (#3030)
5beea32 
Signed-off-by: Rahat Dhande <rahatchd@gmail.com>
(cherry picked from commit fcc505f)
@mergify mergify bot mentioned this pull request Jan 22, 2026
Merged
mergify bot pushed a commit that referenced this pull request Jan 22, 2026
@rahatchd @mergify
fix context in wait for message wait set (#3030)
9c272da 
Signed-off-by: Rahat Dhande <rahatchd@gmail.com>
(cherry picked from commit fcc505f)
@mergify mergify bot mentioned this pull request Jan 22, 2026
Merged
@rahatchd
Copy link
Contributor Author

rahatchd commented Jan 22, 2026

@fujitatomoya fwiw i tried to amend the previous commit here but it was still including the old non-DCO commit somehow. so i assumed that amending commits wasn't going to work

ahcorde pushed a commit that referenced this pull request Jan 23, 2026
@mergify @rahatchd
fix context in wait for message wait set (#3030) (#3032)
d6f7031 
(cherry picked from commit fcc505f)

Signed-off-by: Rahat Dhande <rahatchd@gmail.com>
Co-authored-by: Rahat Dhande <rahatchd@gmail.com>
ahcorde pushed a commit that referenced this pull request Jan 23, 2026
@mergify @rahatchd
fix context in wait for message wait set (#3030) (#3033)
78bc473 
(cherry picked from commit fcc505f)

Signed-off-by: Rahat Dhande <rahatchd@gmail.com>
Co-authored-by: Rahat Dhande <rahatchd@gmail.com>
ahcorde pushed a commit that referenced this pull request Jan 23, 2026
@mergify @rahatchd
fix context in wait for message wait set (#3030) (#3031)
7e4e72c 
(cherry picked from commit fcc505f)

Signed-off-by: Rahat Dhande <rahatchd@gmail.com>
Co-authored-by: Rahat Dhande <rahatchd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rahatchd @fujitatomoya @ahcorde