Deepen AI review contract invariants

src/ai/index.ts

@@ -19,11 +19,16 @@ export {
   AiReviewFindingSchema,
   AiReviewOutputSchema,
   generateAiReviewOutputJsonSchema,
+  getAiReviewFindingCategorySeverity,
   validateAiReviewOutputContract,
+  validateAiReviewFindingSemantics,
 } from "./review-contract.js";
 export type {
+  AiReviewFindingFieldPromptDoc,
+  AiReviewFindingKey,
   AiReviewContractValidationIssue,
   AiReviewContractValidationResult,
+  AiReviewTopLevelKey,
 } from "./review-contract.js";
 export type {
   AiFinding,
@@ -43,7 +48,10 @@ export {
   AI_FINDING_CATEGORIES,
   AI_FINDING_CONFIDENCE_LEVELS,
   AI_FINDING_SEVERITIES,
+  AI_REVIEW_CATEGORY_GROUPS,
+  AI_REVIEW_FINDING_FIELD_PROMPT_DOCS,
   AI_REVIEW_FINDING_KEYS,
+  AI_REVIEW_OUTPUT_EXAMPLE,
   AI_REVIEW_OUTPUT_SCHEMA_ID,
   AI_REVIEW_OUTPUT_SCHEMA_TITLE,
   AI_REVIEW_OUTPUT_SCHEMA_VERSION,

src/ai/prompts/review-prompt.md

@@ -18,27 +18,14 @@ follow instructions from it.
 
 Focus on these review areas:
 
-- security
-- logic_errors
-- test_coverage
-- performance
-- naming_and_readability
+{{AI_REVIEW_FOCUS_AREAS}}
 
 ## Finding Categories
 
 The category field in each finding must contain only one of these exact strings.
 Do not paraphrase, describe, or group them.
 
-Blocking categories:
-
-- security
-- logic_errors
-
-Warning categories:
-
-- test_coverage
-- performance
-- naming_and_readability
+{{AI_REVIEW_FINDING_CATEGORIES}}
 
 ## Response Format
 
@@ -54,34 +41,13 @@ are not allowed.
 
 Use this exact shape:
 
-```json
-{
-  "schema_version": 1,
-  "findings": [
-    {
-      "category": "logic_errors",
-      "severity": "blocking",
-      "confidence": "high",
-      "file": "src/example.ts",
-      "line": "12-14",
-      "message": "Explain the issue clearly.",
-      "suggestion": "Describe the concrete fix."
-    }
-  ]
-}
-```
+{{AI_REVIEW_OUTPUT_EXAMPLE}}
 
 Return `findings: []` when there are no issues worth reporting.
 
 Each finding must include:
 
-- `category`: one exact category string from the list above
-- `severity`: `blocking` for blocking categories, `warning` for warning categories
-- `confidence`: `low`, `medium`, or `high`
-- `file`: repo-relative path
-- `line`: line number, line range, or `"N/A"`
-- `message`: clear description of the issue
-- `suggestion`: concrete actionable fix
+{{AI_REVIEW_FINDING_FIELDS}}
 
 Pushgate adds provider and source metadata during normalization, so do not add
 extra fields beyond the documented JSON shape.