Improve latest-stable doc redirection - #1241
Merged
Merged
Conversation
The current mechanism fails if the symlink `latest-stable` is not set up properly on the server. This is error-prone, as it needs to be updated at every stable release, so we now instead rely on the 404.html to redirect us to the latest stable release. This way `latest-stable` may not exist at all and the redirection will still work properly. Note that this changes the location of the LATEST_RELEASE constant (that still needs to be updated at every release) from selectversion.js to versions.js. selectversion.js now needs versions.js to be included in order to work (this change is done in the root repository).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current mechanism fails if the symlink
latest-stableis not set up properly on the server. This is error-prone, as it needs to be updated at every stable release, so we now instead rely on the 404.html to redirect us to the latest stable release.This way
latest-stablemay not exist at all and the redirection will still work properly.Note that this changes the location of the LATEST_RELEASE constant (that still needs to be updated at every release) from selectversion.js to versions.js. selectversion.js now needs versions.js to be included in order to work (this change is done in the root repository).