[cmake] modernize and simplify RConfigure, RVersion and RConfig generation - #23291
Draft
ferdymercury wants to merge 3 commits into
Draft
[cmake] modernize and simplify RConfigure, RVersion and RConfig generation#23291ferdymercury wants to merge 3 commits into
ferdymercury wants to merge 3 commits into
Conversation
inbuilt configure file and mention also current cplusplus not just ROOT in error message
via header guards
ferdymercury
changed the title
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 9838ed6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
skip-ci, posting here just to give the idea.
Builds on top of #23261
It opens up the possibility of not having to depend everything on Core if one just wants RConfig / RConfigure headers.
Follow-up also have Rtypes.h outside of Core. Would disentangle some build dependencies. Maybe it helps for #6432
And to work also on root-config https://its.cern.ch/jira/browse/ROOT-8061