[RF] do not rely on a backward compatibility header - #23285
Open
ferdymercury wants to merge 9 commits into
Open
Conversation
use instead standard C++ headers, more fine-grained and cleanup some unused headers on the go
ferdymercury
added
the
skip code analysis
guitargeek
reviewed
Sep 7, 2026
guitargeek
reviewed
Sep 7, 2026
guitargeek
reviewed
Sep 7, 2026
guitargeek
requested changes
Sep 7, 2026
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
Thanks you very much, looks already great! I just think a new un-needed whitespace changes sneaked in, no?
ferdymercury
commented
Sep 7, 2026
ferdymercury
commented
Sep 7, 2026
ferdymercury
commented
Sep 7, 2026
Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
Member
|
Thanks for these changes. Can it be that we broke gcc 10 on Alma on ARM64? https://github.com/root-project/root/actions/runs/34127115556/job/101758284214?pr=23285#step:8:3050 |
Collaborator
Author
Thanks! Yep, good catch. It's fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use instead standard C++ headers, more fine-grained
and cleanup some unused headers on the go