[core] deprecate Rstrstream.h

README/ReleaseNotes/v642/index.md

@@ -67,8 +67,9 @@ Users are encouraged to export their models to ONNX and use the retained ONNX pa
 * The **RooStats::DebuggingSampler** and **RooStats::DebuggingTestStat** classes are removed. They were mock implementations of the `TestStatSampler` and `TestStatistic` interfaces that returned uniform random numbers independent of the data, only meant for debugging the RooStats framework itself during its initial development.
 * The `RooTrace` class is deprecated and will be removed in ROOT 6.44. It was a RooFit-specific memory tracer whose instrumentation hooks are compiled out by default, so it has been inert and untested for years. For memory debugging, please use general-purpose tools such as AddressSanitizer or Valgrind instead.
 * Support for the AIX operating system has been removed from the codebase. This support has not been tested since the late v5 releases and the LLVM JIT is not yet supporting AIX.
-* The headers Htypes.h and Gtypes.h that were deprecated in ROOT 6.20 will now emit warnings and will be fully removed in ROOT 6.44.
-* The header GLConstants.h is no longer part of ROOT installed headers.
+* The headers `Htypes.h` and `Gtypes.h` that were deprecated in ROOT 6.20 will now emit warnings and will be fully removed in ROOT 6.44. Use instead `Rtypes.h`.
+* The header `GLConstants.h` is no longer part of ROOT installed headers.
+* The header `Rstrstream.h` is deprecated and will be removed after ROOT 6.44, use instead `<sstream>`.
 * The `ROOT::Math::ParamFunctionBase`, `ROOT::Math::ParamFunctorHandler` and `ROOT::Math::ParamMemFunHandler` classes in `Math/ParamFunctor.h` are removed, together with the `ParamFunctor::GetImpl()` and `ParamFunctor::SetFunction()` methods that exposed them. They implemented the type erasure that `ParamFunctor` now gets from `std::function`, mirroring what was already done for `ROOT::Math::Functor`. Constructing and calling a `ParamFunctor` is unchanged, except that the constructor from an object and one of its member functions now takes a plain pointer to the object instead of anything dereferenceable, so smart pointers are no longer accepted there.
 
 ## Build System

core/foundation/inc/Rstrstream.h

@@ -12,6 +12,8 @@
 #ifndef ROOT_Rstrstream
 #define ROOT_Rstrstream
 
+#warning "This header is deprecated and will be removed after ROOT 6.44, used instead <sstream>"
+
 #include <ROOT/RConfig.hxx>
 
 #if defined(R__ANSISTREAM)

core/foundation/src/TClassEdit.cxx

@@ -12,13 +12,15 @@
  * For the list of contributors see $ROOTSYS/README/CREDITS.             *
  *************************************************************************/
 
+#include "TClassEdit.h"
+#include "TSpinLockGuard.h"
+
 #include <cstdio>
 #include <cstdlib>
 #include <cassert>
 #include <cstring>
-#include "TClassEdit.h"
 #include <cctype>
-#include "Rstrstream.h"
+#include <sstream>
 #include <set>
 #include <stack>
 // for shared_ptr
@@ -27,8 +29,6 @@
 #include <algorithm>
 #include <string>
 
-#include "TSpinLockGuard.h"
-
 using std::string, std::string_view, std::vector, std::set;
 
 namespace {

core/rint/src/TTabCom.cxx

@@ -121,10 +121,6 @@
 //                                                                        //
 ////////////////////////////////////////////////////////////////////////////
 
-#include <cstdio>
-#include <cassert>
-#include <set>
-
 #include "RConfigure.h"
 #include "TTabCom.h"
 #include "TClass.h"
@@ -145,9 +141,13 @@
 #include "TMethodArg.h"
 #include "TInterpreter.h"
 #include "Riostream.h"
-#include "Rstrstream.h"
 #include "strlcpy.h"
 
+#include <cstdio>
+#include <cassert>
+#include <set>
+#include <sstream>
+
 #define BUF_SIZE 1024 // must be smaller than/equal to fgLineBufSize in Getline.cxx and
                       // lineBufSize in cppcompleter.py
 #define IfDebug(x)  if(gDebug==TTabCom::kDebug) x

tmva/tmva/src/GeneticPopulation.cxx

@@ -29,16 +29,14 @@ Population definition for genetic algorithm.
 
 */
 
-#include <algorithm>
-
-#include "Rstrstream.h"
 #include "TRandom3.h"
 #include "TH1.h"
 
 #include "TMVA/GeneticPopulation.h"
 #include "TMVA/GeneticGenes.h"
 #include "TMVA/MsgLogger.h"
 
+#include <sstream>
 
 using std::vector, std::ostream;