Skip to content

[core] emit warning for header deprecated in ROOT 6.14 - #23272

Open
ferdymercury wants to merge 4 commits into
root-project:masterfrom
ferdymercury:patch-24
Open

[core] emit warning for header deprecated in ROOT 6.14#23272
ferdymercury wants to merge 4 commits into
root-project:masterfrom
ferdymercury:patch-24

Conversation

@ferdymercury

@ferdymercury ferdymercury commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Sep 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 15h 58m 20s ⏱️
 3 877 tests  3 872 ✅ 0 💤 5 ❌
78 905 runs  78 900 ✅ 0 💤 5 ❌

For more details on these failures, see this check.

Results for commit b38fdab.

♻️ This comment has been updated with latest results.

@ferdymercury
ferdymercury marked this pull request as ready for review September 6, 2026 16:42
jblomer
jblomer reviewed Sep 6, 2026
View reviewed changes

@jblomer jblomer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we haven't issue a compiler warning before, I think we should remove it only in 6.46.

@jblomer jblomer self-assigned this Sep 6, 2026
ferdymercury
ferdymercury commented Sep 7, 2026
View reviewed changes
Comment thread core/foundation/inc/RStringView.h Outdated
Comment thread README/ReleaseNotes/v642/index.md Outdated
@ferdymercury
ferdymercury requested a review from jblomer September 7, 2026 05:27
@dpiparo

dpiparo commented Sep 7, 2026

Copy link
Copy Markdown
Member

thanks for this proposal! Currently, the last foreseen ROOT 6 version is 6.44. Therefore the 6.46 warning seems incorrect.

@ferdymercury

ferdymercury commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator Author

thanks for this proposal! Currently, the last foreseen ROOT 6 version is 6.44. Therefore the 6.46 warning seems incorrect.

Would it be then ok to say it will be removed in 6.44 ? It was deprecated in 6.14, so even if there were no warnings, it's a lot of time since then already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner
@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner
@pcanal pcanal Awaiting requested review from pcanal pcanal is a code owner
@jblomer jblomer Awaiting requested review from jblomer

At least 1 approving review is required to merge this pull request.

Assignees

@jblomer jblomer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ferdymercury @dpiparo @jblomer