[rfile] Allow setting object titles when writing#22898
Open
silverweed wants to merge 4 commits into
Open
Conversation
silverweed
requested review from
dpiparo,
enirolf,
hageboeck,
hahnjo and
vepadulano
July 23, 2026 08:29
Test Results 22 files 22 suites 3d 14h 48m 1s ⏱️ For more details on these failures, see this check. Results for commit 4741af9. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
rfile_cleanups
branch
from
July 23, 2026 11:26
dadb182 to
4741af9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Adds the ability of storing object titles when writing objects to RFile.
CAVEATS/to be discussed:
rfile->Put("obj", obj, obj->GetTitle()));rfile->Put("obj", myTObject, "My Title")will not setmyTObject's title, but only its key's. This means that this potentially unexpected behavior will occur:In order to retrieve the object's title you'd need to do it from the key:
To be discussed: are we ok with this behavior or do we want bespoke TObject/TNamed code in the implementation to mitigate these pitfalls?