[tmva][sofie] Merge operator .icc files into main .hxx files#21580
Open
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Open
[tmva][sofie] Merge operator .icc files into main .hxx files#21580guitargeek wants to merge 1 commit intoroot-project:masterfrom
.icc files into main .hxx files#21580guitargeek wants to merge 1 commit intoroot-project:masterfrom
Conversation
Artificially splitting up the header files into two files has usually no clear benefit to me. When expanding the includes, the headers are still long, so it doesn't reduce compile time, and for the developer it's easier to think about code and make changes when the class definition and implementation is in one place. Also, `.icc` is not a usual source file extension, so lots of tooling doesn't work, like clang-tidy (by default) or syntax highlighting and autocomplete in some editors. So I would suggest to move the code all into the header files, to keep things simple and consistent. When moving the code in this commit, it is also formatted with clang-format.
Test Results 22 files 22 suites 3d 4h 47m 13s ⏱️ Results for commit 3d05afd. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Artificially splitting up the header files into two files has usually no clear benefit to me. When expanding the includes, the headers are still long, so it doesn't reduce compile time, and for the developer it's easier to think about code and make changes when the class definition and implementation is in one place.
Also,
.iccis not a usual source file extension, so lots of tooling doesn't work, like clang-tidy (by default) or syntax highlighting and autocomplete in some editors.So I would suggest to move the code all into the header files, to keep things simple and consistent.
When moving the code in this commit, it is also formatted with clang-format.