[6.36][ntuple] use only "true type name" for class members#21437
Open
jblomer wants to merge 1 commit intoroot-project:v6-36-00-patchesfrom
Open
[6.36][ntuple] use only "true type name" for class members#21437jblomer wants to merge 1 commit intoroot-project:v6-36-00-patchesfrom
jblomer wants to merge 1 commit intoroot-project:v6-36-00-patchesfrom
Conversation
jblomer
force-pushed
the
ntuple-v636-fix-type-alias-member
branch
from
475af1a to
106ee5d
Compare
Do not set the full type name as type alias. Pass only the true type name to RFieldBase::Create(). The true type name will contain Long64_t and Double32_t type name tokens, so we are still able to treat those correctly. The full type name would provide additional information. However, normalizing the full type name can cause header auto parsing. Also, the full type name, in general, cannot be used directly because it may be a type that is only valid within the class context. (cherry picked from commit 054886d)
Test Results 17 files 17 suites 2d 8h 27m 17s ⏱️ Results for commit 106ee5d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #21373