[RF] Support analytical Hessians with Clad#21416
Open
guitargeek wants to merge 2 commits intoroot-project:masterfrom
Open
[RF] Support analytical Hessians with Clad#21416guitargeek wants to merge 2 commits intoroot-project:masterfrom
guitargeek wants to merge 2 commits intoroot-project:masterfrom
Conversation
guitargeek
force-pushed
the
roofit_hessians
branch
2 times, most recently
from
05426d7 to
8b83639
Compare
guitargeek
force-pushed
the
roofit_hessians
branch
2 times, most recently
from
ad4c51b to
ab5c8cc
Compare
Implement all the necessary infrastructure to optionally generate Hessians with Clad via RooFit "codegen", and forward them to Minuit 2, including also validation code in the debug macro that can be printed out for RooFit functions that support "codegen". This addresses an Item from the ROOT 2026 plan of work. It doesn't work yet, because a new Clad release is required, where this issue is fixed: vgvassilev/clad#1736 However, it's already good to have all the necessary changes in ROOT so we can test and validate Clad developments for Hessian support more easily.
Differentiating through Cling runtime checks in pointer dereferncing can result in errors: ```txt warning: attempted differentiation of function 'cling_runtime_internal_throwIfInvalidPointer' without definition and no suitable overload was found in namespace 'custom_derivatives' note: numerical differentiation is not viable for 'cling_runtime_internal_throwIfInvalidPointer'; considering 'cling_runtime_internal_throwIfInvalidPointer' as 0 <<< cling interactive line includer >>>:1:1: error: read-only variable is not assignable ^ ```
guitargeek
force-pushed
the
roofit_hessians
branch
from
ab5c8cc to
cedcb15
Compare
Test Results 22 files 22 suites 3d 5h 26m 21s ⏱️ Results for commit cedcb15. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement all the necessary infrastructure to optionally generate Hessians with Clad via RooFit "codegen", and forward them to Minuit 2, including also validation code in the debug macro that can be printed out for RooFit functions that support "codegen".
This addresses an Item from the ROOT 2026 plan of work.
It doesn't work yet, because a new Clad release is required, where this issue is fixed:
vgvassilev/clad#1736
However, it's already good to have all the necessary changes in ROOT so we can test and validate Clad developments for Hessian support more easily.