[ML] Refactor the data loader headers#21397
Open
siliataider wants to merge 1 commit intoroot-project:masterfrom
Open
[ML] Refactor the data loader headers#21397siliataider wants to merge 1 commit intoroot-project:masterfrom
siliataider wants to merge 1 commit intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 8h 58m 21s ⏱️ Results for commit 3afd413. ♻️ This comment has been updated with latest results. |
siliataider
force-pushed
the
batchgenerator
branch
3 times, most recently
from
9f68080 to
42365a1
Compare
siliataider
force-pushed
the
batchgenerator
branch
3 times, most recently
from
2133fa2 to
3afd413
Compare
siliataider
requested review from
bellenot,
jblomer and
vepadulano
as code owners
jblomer
reviewed
Mar 4, 2026
Contributor
jblomer
left a comment
jblomer
left a comment
There was a problem hiding this comment.
The format changes in the DAOS source file are ok but should go in another PR, I think.
On the subject of the PR: LGTM. See the remaining clang-format issue though. Generally, I think it is nice if within an include block, the includes are ordered alphabetically, which I think is not always the case.
siliataider
force-pushed
the
batchgenerator
branch
2 times, most recently
from
f9fdbed to
35b2e02
Compare
Contributor
Author
|
Thanks @jblomer , my bad, the changes in the DAOS source file mistakenly got dragged into this PR, just removed them 👍🏻 |
siliataider
force-pushed
the
batchgenerator
branch
from
35b2e02 to
b098802
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
This PR reorganizes the data loader headers, and refactors some of the includes, into the following structure:
tree/ml/inc/ROOT/ML/RBatchGenerator.hxxnot split (templated)tree/ml/inc/ROOT/ML/RBatchLoader.hxxsplit intotree/ml/inc/ROOT/ML/RBatchLoader.hxxtree/ml/src/RBatchLoader.cxxtree/ml/inc/ROOT/ML/RChunkConstructor.hxxsplit intotree/ml/inc/ROOT/ML/RChunkConstructor.hxxtree/ml/src/RChunkConstructor.cxxtree/ml/inc/ROOT/ML/RChunkLoader.hxxnot split (templated)tree/ml/inc/ROOT/ML/RDatasetLoader.hxxnot split (templated)tree/ml/inc/ROOT/ML/RFlat2DMatrix.hxxnot split (not templated but trivial, mostly contains one liners)tree/ml/inc/ROOT/ML/RFlat2DMatrixOperators.hxxsplit intotree/ml/inc/ROOT/ML/RFlat2DMatrixOperators.hxxtree/ml/src/RFlat2DMatrixOperators.cxxtree/ml/inc/ROOT/ML/RSampler.hxxsplit intotree/ml/inc/ROOT/ML/RSampler.hxxtree/ml/src/RSampler.cxxChecklist: