[tmva][sofie] Add unit test for ONNX GELU operator parsing#21357
Open
MrViiV wants to merge 1 commit intoroot-project:masterfrom
Open
[tmva][sofie] Add unit test for ONNX GELU operator parsing#21357MrViiV wants to merge 1 commit intoroot-project:masterfrom
MrViiV wants to merge 1 commit intoroot-project:masterfrom
Conversation
guitargeek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a unit test for the ONNX GELU operator in the SOFIE ONNX parser.
GELU is widely used in modern neural network architectures such as Transformers and BERT. Adding a dedicated unit test helps validate the parser behavior, improve test coverage, and prevent regressions as GELU operator support evolves.
Changes
Added TestGelu.cxx in tmva/sofie/test
Added gelu.onnx test model
Notes
I am happy to update the test to follow any specific ROOT testing conventions if needed.