[REve] Update to RenderCore release from github, deploy it as builtin tarball#11936
[REve] Update to RenderCore release from github, deploy it as builtin tarball#11936Axel-Naumann merged 2 commits intoroot-project:masterfrom
Conversation
… tarball. - Move some RenderCore specific classes and all shaders into RenderCore source tree. - Implement all existing Three.js functionality with RenderCore. - In RenderCore, further improve on existing functionality: - Textured points - arbitrary size and shape. - Mesh lines - arbitrary thickness. - Object and sub-object picking through color buffer with fragment depth detection. - Camera handling like in TEve, with ability to pick rotation center. C++ / Server Changes - REveManager: Make RenderCore the default rendering engine. - Stream interpreter errors and show them in client log - Add flag fIsRCore to REveManager. - Make REvePointSet secondary-selectable. - Add parameter for projection depth in REveDataCollection JS / Client Changes - Remove error MessageBox popup during client updates. - EveManager.js: Check change bits in ImportSceneBinary when scene changes are streamed. - EveScene.js: Optimize visibility changes. - EveScene.js: pass eve_element instead of object3d in cases where it simplifies the code. - EveScene.js, GlViewer classes: Cleamup highlite/selection management so it can be abstracted for RCore. - Separate viewer-side selection processing for Three / RCore. Tutorials / Demos Changes - event_demo.C: secondary select points, jet title include pT. - Tune marker sizes, colors, visual parameters.
osschar
requested review from
Axel-Naumann,
bellenot,
couet and
linev
as code owners
|
Starting build on |
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Warnings:
|
linev
left a comment
linev
left a comment
There was a problem hiding this comment.
Looks ok.
I test several tutorials - all them work.
|
Can we please have the warning fixed? |
|
Starting build on |
|
@Axel-Naumann Warning should be fixed now by my commit |
|
Build failed on windows10/cxx14. |
|
@phsft-bot build just on windows10/cxx14 |
|
Starting build on |
4 participants
Move some RenderCore specific classes and all shaders into RenderCore source tree.
Implement all existing Three.js functionality with RenderCore.
In RenderCore, further improve on existing functionality:
The development branch has been squashed to hide redundant changes. Full history is available in PR [REve] Update to RenderCore release from github, deploy it as builtin tarball. osschar/root#41.
C++ / Server Changes
REveManager: Make RenderCore the default rendering engine.
Stream interpreter errors and show them in client log
Add flag fIsRCore to REveManager.
Make REvePointSet secondary-selectable.
Add parameter for projection depth in REveDataCollection
JS / Client Changes
Remove error MessageBox popup during client updates.
EveManager.js: Check change bits in ImportSceneBinary when scene changes are streamed.
EveScene.js: Optimize visibility changes.
EveScene.js: pass eve_element instead of object3d in cases where it simplifies the code.
EveScene.js, GlViewer classes: Cleamup highlite/selection management so it can be abstracted for RCore.
Separate viewer-side selection processing for Three / RCore.
Tutorials / Demos Changes
event_demo.C: secondary select points, jet title include pT.
Tune marker sizes, colors, visual parameters.