Skip to content

[ntuple] Fix decodeZigzag64 for SplitInt64 columns #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linev merged 1 commit into from
Jul 24, 2026
+3 −3
Merged

[ntuple] Fix decodeZigzag64 for SplitInt64 columns #410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions modules/rntuple.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,9 @@
* @private */
function decodeZigzag64(view) {
for (let o = 0; o < view.byteLength; o += 8) {
const x = view.getUint64(o, LITTLE_ENDIAN);
view.setInt64(o, (x >>> 1) ^ (-(x & 1)), LITTLE_ENDIAN);
}
const x = view.getBigUint64(o, LITTLE_ENDIAN);

Check warning on line 237 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-ubuntu (24.x, g++-13) 

Expected indentation of 6 spaces but found 8

Check warning on line 237 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-ubuntu (22.x, g++-13) 

Expected indentation of 6 spaces but found 8

Check warning on line 237 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-ubuntu (20.x, g++-14) 

Expected indentation of 6 spaces but found 8

Check warning on line 237 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-ubuntu (20.x, g++-13) 

Expected indentation of 6 spaces but found 8

Check warning on line 237 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-macos (24.x) 

Expected indentation of 6 spaces but found 8

Check warning on line 237 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-ubuntu (24.x, g++-14) 

Expected indentation of 6 spaces but found 8

Check warning on line 237 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-macos (20.x) 

Expected indentation of 6 spaces but found 8

Check warning on line 237 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-macos (22.x) 

Expected indentation of 6 spaces but found 8

Check warning on line 237 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-ubuntu (22.x, g++-14) 

Expected indentation of 6 spaces but found 8

Check warning on line 237 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-windows (22.x) 

Expected indentation of 6 spaces but found 8

Check warning on line 237 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-windows (20.x) 

Expected indentation of 6 spaces but found 8

Check warning on line 237 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-windows (24.x) 

Expected indentation of 6 spaces but found 8
view.setBigInt64(o, (x >> 1n) ^ (-(x & 1n)), LITTLE_ENDIAN);

Check warning on line 238 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-ubuntu (24.x, g++-13) 

Expected indentation of 6 spaces but found 8

Check warning on line 238 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-ubuntu (22.x, g++-13) 

Expected indentation of 6 spaces but found 8

Check warning on line 238 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-ubuntu (20.x, g++-14) 

Expected indentation of 6 spaces but found 8

Check warning on line 238 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-ubuntu (20.x, g++-13) 

Expected indentation of 6 spaces but found 8

Check warning on line 238 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-macos (24.x) 

Expected indentation of 6 spaces but found 8

Check warning on line 238 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-ubuntu (24.x, g++-14) 

Expected indentation of 6 spaces but found 8

Check warning on line 238 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-macos (20.x) 

Expected indentation of 6 spaces but found 8

Check warning on line 238 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-macos (22.x) 

Expected indentation of 6 spaces but found 8

Check warning on line 238 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-ubuntu (22.x, g++-14) 

Expected indentation of 6 spaces but found 8

Check warning on line 238 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-windows (22.x) 

Expected indentation of 6 spaces but found 8

Check warning on line 238 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-windows (20.x) 

Expected indentation of 6 spaces but found 8

Check warning on line 238 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-windows (24.x) 

Expected indentation of 6 spaces but found 8
}

Check warning on line 239 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-ubuntu (24.x, g++-13) 

Expected indentation of 3 spaces but found 4

Check warning on line 239 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-ubuntu (22.x, g++-13) 

Expected indentation of 3 spaces but found 4

Check warning on line 239 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-ubuntu (20.x, g++-14) 

Expected indentation of 3 spaces but found 4

Check warning on line 239 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-ubuntu (20.x, g++-13) 

Expected indentation of 3 spaces but found 4

Check warning on line 239 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-macos (24.x) 

Expected indentation of 3 spaces but found 4

Check warning on line 239 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-ubuntu (24.x, g++-14) 

Expected indentation of 3 spaces but found 4

Check warning on line 239 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-macos (20.x) 

Expected indentation of 3 spaces but found 4

Check warning on line 239 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-macos (22.x) 

Expected indentation of 3 spaces but found 4

Check warning on line 239 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-ubuntu (22.x, g++-14) 

Expected indentation of 3 spaces but found 4

Check warning on line 239 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-windows (22.x) 

Expected indentation of 3 spaces but found 4

Check warning on line 239 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-windows (20.x) 

Expected indentation of 3 spaces but found 4

Check warning on line 239 in modules/rntuple.mjs

View workflow job for this annotation

GitHub Actions / build-windows (24.x) 

Expected indentation of 3 spaces but found 4
}


Expand Down
Loading