Stop claiming Hasheous supplies RetroAchievements IDs - #162
Merged
Merged
Conversation
RomM matches RetroAchievements by hash only since rommapp/romm#4962 (the fix for rommapp/romm#4959), so Hasheous no longer provides RA IDs. Describe what Hasheous still supplies, explain how RA matching works and what it needs, and note that disc images inside archives get no RA match from a scan (rommapp/romm#4967). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FoxH511V1d31hAA2tWvw3Q
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FoxH511V1d31hAA2tWvw3Q
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation reflects upstream behavior, with only a non-blocking clarification about existing matches remaining.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates RomM’s metadata-provider documentation to reflect hash-only RetroAchievements matching.
Changes:
- Removes the claim that Hasheous supplies RetroAchievements IDs.
- Explains hashing requirements, archive limitations, and manual matching options.
| File | Description |
|---|---|
docs/getting-started/metadata-providers.md |
Corrects provider capabilities and documents RetroAchievements matching behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gantoine
requested changes
Oct 4, 2026
gantoine
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After rommapp/romm#4962 (the fix for rommapp/romm#4959), RomM matches RetroAchievements by hash only and no longer takes RA IDs from Hasheous. The Metadata Providers page still said Hasheous "can provide Retroachievements IDs for matched games".
Changes to
docs/getting-started/metadata-providers.md:filesystem.skip_hash_calculation.(ra-12345)filename tag also works.I searched the rest of the repo for Hasheous near RetroAchievements/RA. The only other mentions say that skipping hashing loses RetroAchievements and Hasheous matching, which is still true, so I left them as they are.
Release timing
This describes behavior from rommapp/romm#4962. Please deploy it with the RomM version that ships that change, not onto an older version's docs.
Checks
uv run mkdocs build --strictpassesuv run python -m scripts.check_redirectspassestrunk checkhere because its plugin download was blocked. Running prettier 3.5.2 and markdownlint 0.45 on the page directly found nothing new on the changed lines.AI assistance disclosure
Claude Code wrote this change from a handoff describing rommapp/romm#4959 and #4962. A human should check the wording against the merged RomM behavior before merging.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FoxH511V1d31hAA2tWvw3Q