Add formatter for the logstash-logger gem#374
Open
Nowaker wants to merge 1 commit intoroidrage:masterfrom
Open
Add formatter for the logstash-logger gem#374Nowaker wants to merge 1 commit intoroidrage:masterfrom
Nowaker wants to merge 1 commit intoroidrage:masterfrom
Conversation
Allows for the added payload fields in lograge to surface in logs outside of just controller logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #303 rebased against master.
Not that my feedback from #303 (comment) still applies - it's not an ideal implementation... but it works. It's been in production of a huge site for one year now.
For reference,
RequestStore.store[:lograge_event_payload]is what this original PR adds to Lograge core, and then formatters or other custom loggers. Like my logger that is set asRails.loggerand therefore each non-Lograge line includes what Lograge logs for that request.