Repository navigation
Name the Kodein JDBC files after what they hold - #66
Merged
Merged
Conversation
JdbcModule.kt holds jdbcDataSourceModule, and SqliteModule.kt, MysqlModule.kt and PostgresqlModule.kt each hold a driver module's config module. Rename them to JdbcDataSourceModule.kt and SqliteConfigSource.kt etc., matching the Inara flavor's files. The files are new since 3.0.0, so their file classes changing breaks no published binary.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames four Kodein flavor files for clarity:
boot-db-jdbc/.../JdbcModule.ktJdbcDataSourceModule.ktjdbcDataSourceModuleboot-db-jdbc-sqlite/.../SqliteModule.ktSqliteConfigSource.ktsqliteConfigModuleboot-db-jdbc-mysql/.../MysqlModule.ktMysqlConfigSource.ktmysqlConfigModuleboot-db-jdbc-postgresql/.../PostgresqlModule.ktPostgresqlConfigSource.ktpostgresqlConfigModuleThe contents are unchanged. The files are new since 3.0.0, so the change to their JVM file classes breaks no published binary.
The JDBC, SQLite, MySQL and PostgreSQL modules build, with their tests, and so does the Kodein server example.