simplify stakeRPL by removing unnecessary checks #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As stakeRPL can only be called by the registered node ("onlyRegisteredNode(msg.sender)" modifier), there is no need to check if the caller is either of the withdrawal addresses.
kanewallmann
force-pushed
the
v1.4
branch
3 times, most recently
from
7a8aefe to
e69b728
Compare
kanewallmann
force-pushed
the
v1.4
branch
5 times, most recently
from
fdfb7d6 to
8f0a026
Compare
kanewallmann
force-pushed
the
v1.4
branch
2 times, most recently
from
2e600cb to
9b0fee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stakeRPL can only be called by the registered node (
onlyRegisteredNode(msg.sender)modifier), there is no need to check if the caller is either of the withdrawal addresses.