Skip to content

fix: update password handling in proxy connection DTO to match upstream credentials #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artuomka merged 1 commit into from
Apr 27, 2026
Merged

fix: update password handling in proxy connection DTO to match upstream credentials #1739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions backend/test/ava-tests/saas-tests/saas-postgres-proxy-e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ import http from 'http';
import net from 'net';
import request from 'supertest';
import { ApplicationModule } from '../../../src/app.module.js';
import { WinstonLogger } from '../../../src/entities/logging/winston-logger.js';
import { AllExceptionsFilter } from '../../../src/exceptions/all-exceptions.filter.js';
import { ValidationException } from '../../../src/exceptions/custom-exceptions/validation-exception.js';
import { Cacher } from '../../../src/helpers/cache/cacher.js';
import { DatabaseModule } from '../../../src/shared/database/database.module.js';
import { DatabaseService } from '../../../src/shared/database/database.service.js';
import { WinstonLogger } from '../../../src/entities/logging/winston-logger.js';
import { createTestTable } from '../../utils/create-test-table.js';
import {
createInitialTestUser,
Expand Down Expand Up @@ -46,7 +46,9 @@ const upstreamConnectionParams = {
// Connection DTO that points to the proxy (used in rocketadmin API).
// Each call returns a unique username so the mock-api derives a unique
// companyId — this isolates each test's connection pool inside the proxy's
// per-company concurrency limiter.
// per-company concurrency limiter. The password must match the upstream
// password the mock-api hands back to the proxy, since the proxy now
// verifies client-supplied credentials before forwarding.
function createProxyConnectionDto(): {
title: string;
type: string;
Expand All @@ -65,7 +67,7 @@ function createProxyConnectionDto(): {
host: PROXY_HOST,
port: PROXY_PORT,
username,
password: 'proxy_pass',
password: upstreamConnectionParams.password,
database: 'postgres',
ssh: false,
ssl: false,
Expand Down
Loading