Skip to content

refactor: simplify connection retrieval in GetHostedConnectionCredentialsUseCase #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artuomka merged 1 commit into from
Apr 24, 2026
Merged

refactor: simplify connection retrieval in GetHostedConnectionCredentialsUseCase #1734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...c/microservices/saas-microservice/use-cases/get-hosted-connection-credentials.use.case.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@ export class GetHostedConnectionCredentialsUseCase
}

protected async implementation(inputData: GetHostedConnectionCredentialsDto): Promise<HostedConnectionCredentialsRO> {
const connection = await this._dbContext.connectionRepository.findOne({
where: { id: inputData.hostedDatabaseId },
});
const connection = await this._dbContext.connectionRepository.findOneConnection(inputData.hostedDatabaseId);
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

findOneConnection() has side effects (it generates signing_key when missing and persists the entity) and also loads connection_properties. For a credentials-read use case this introduces an unexpected write + extra join overhead. Prefer using connectionRepository.findOneById(hostedDatabaseId) (it decrypts credentials without mutating) or a dedicated read-only method without the signing_key backfill.

Suggested change
const connection = await this._dbContext.connectionRepository.findOneConnection(inputData.hostedDatabaseId);
const connection = await this._dbContext.connectionRepository.findOneById(inputData.hostedDatabaseId);

Copilot uses AI. Check for mistakes.
if (!connection) {
throw new NotFoundException(Messages.CONNECTION_NOT_FOUND);
}
Expand Down
Loading