Skip to content

fix incompatible fast-xml-parser #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gugu merged 1 commit into from
Apr 23, 2026
Merged

fix incompatible fast-xml-parser #1731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
"lodash@>=4.0.0 <=4.17.23": ">=4.18.0",
"lodash@<=4.17.23": ">=4.18.0",
"@nestjs/core@<=11.1.17": ">=11.1.18",
"fast-xml-parser@<5.7.0": ">=5.7.0",
"uuid@<14.0.0": ">=14.0.0"
Comment on lines 29 to 32
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the PR title ('fix incompatible fast-xml-parser'), removing the override entirely may make installs drift over time (depending on transitive dependency resolution) and can allow reintroducing the previously-problematic version range. Consider pinning fast-xml-parser to a known-compatible range (either via overrides or an explicit direct dependency where it's used) and/or document in the PR description which versions are incompatible and why.

Copilot uses AI. Check for mistakes.
Comment on lines 29 to 32
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this repository uses a lockfile (e.g., package-lock.json, pnpm-lock.yaml, or yarn.lock), this change should be accompanied by a lockfile update so CI and local installs are reproducible and the override removal actually takes effect consistently.

Copilot uses AI. Check for mistakes.
},
"packageExtensions": {
Expand Down
15 changes: 4 additions & 11 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading