added getfile path #2
Open
behnamasadi wants to merge 4 commits intorock-simulation:masterfrom
behnamasadi:master
Open
added getfile path #2behnamasadi wants to merge 4 commits intorock-simulation:masterfrom behnamasadi:master
behnamasadi wants to merge 4 commits intorock-simulation:masterfrom
behnamasadi:master
Conversation
Author
|
added getfile path |
Contributor
|
Hi Behnam, sorry to delay this again, but it seems you didn't change the header file along with the implementation. We should fix that before we merge into master. And while we're on it, we might as well make the commit history nicer, after all ;) Cheers, Kai |
Author
|
sure, I will clean it up and send an other request next week ;) |
The private function "resolve_path" has been added to translate relative addresses to absolute address without pain. A test file for test the code as been also added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added getfile path