Repository navigation
Retire removed bots in the catalog and keep its history - #39
Merged
Merged
Conversation
Deleting a bot's directory left its catalog entry "active", so Rumble clients would fail on the missing directory. Catalog generation now marks such entries "retired". It also keeps superseded and other non-active entries on every regeneration; before, the next regeneration silently dropped them. A retired bot's name stays reserved for its owner but no longer counts as an active slot. Catalog verification accepts a merged source PR that only deletes bot directories, after checking they are gone from main and that no unpublished bot changes would be attributed to it. The validator tests build their Python fixture bot from the official template instead of relying on the live Orbit bot, which is about to be retired.
Contributor
|
@robocode-dev/rumble-moderators Moderation needs your decision for The required check stays pending. After reviewing, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
active, so Rumble clients would fail on the missing directory.supersededentries (on 2026-10-27, RumbleTestScout's history disappeared).Changes
scripts/validate_bot.py: an active entry whose bot directory is gone becomesretired; every non-active entry is kept as history;activeSlotscounts only present bots, while retired names stay reserved for their owner.moderation/verify_catalog.py: accepts a source PR that only deletes bot directories, after checking they are gone from main and that no unpublished bot change would be attributed to it.GOVERNANCE.md: how moderators retire bots.Rehearsed in the test Rumble
Same change as robocode-dev/rumble-bots-test#15. The removal-only robocode-dev/rumble-bots-test#16 (TestEcho, TestEchoTwo) escalated, was approved, merged, and the publisher's catalog PR robocode-dev/rumble-bots-test#17 passed verification and merged automatically with both bots
retired.Next
A removal-only PR retires Orbit, OrbitVector, Vector, RumbleOnboardingScout and RumbleTestScout, which were used only for testing before the test Rumble existed.