Skip to content

Retire removed bots in the catalog and keep its history - #39

Merged
flemming-n-larsen merged 1 commit into
mainfrom
retire-removed-bots
Nov 15, 2026
Merged

flemming-n-larsen merged 1 commit into
mainfrom
retire-removed-bots

Conversation

@flemming-n-larsen

Copy link
Copy Markdown
Contributor

Problem

  • Deleting a bot's directory left its catalog entry active, so Rumble clients would fail on the missing directory.
  • Regenerating the catalog silently dropped superseded entries (on 2026-10-27, RumbleTestScout's history disappeared).
  • Catalog verification only accepted a source PR that changed exactly one bot directory, so a PR that removes several bots could not publish.

Changes

  • scripts/validate_bot.py: an active entry whose bot directory is gone becomes retired; every non-active entry is kept as history; activeSlots counts only present bots, while retired names stay reserved for their owner.
  • moderation/verify_catalog.py: accepts a source PR that only deletes bot directories, after checking they are gone from main and that no unpublished bot change would be attributed to it.
  • Tests: the validator fixture builds its Python bot from the official template instead of the live Orbit; new tests cover retirement, history retention and removal-only verification.
  • GOVERNANCE.md: how moderators retire bots.

Rehearsed in the test Rumble

Same change as robocode-dev/rumble-bots-test#15. The removal-only robocode-dev/rumble-bots-test#16 (TestEcho, TestEchoTwo) escalated, was approved, merged, and the publisher's catalog PR robocode-dev/rumble-bots-test#17 passed verification and merged automatically with both bots retired.

Next

A removal-only PR retires Orbit, OrbitVector, Vector, RumbleOnboardingScout and RumbleTestScout, which were used only for testing before the test Rumble existed.

Deleting a bot's directory left its catalog entry "active", so Rumble clients
would fail on the missing directory. Catalog generation now marks such entries
"retired". It also keeps superseded and other non-active entries on every
regeneration; before, the next regeneration silently dropped them. A retired
bot's name stays reserved for its owner but no longer counts as an active slot.

Catalog verification accepts a merged source PR that only deletes bot
directories, after checking they are gone from main and that no unpublished bot
changes would be attributed to it.

The validator tests build their Python fixture bot from the official template
instead of relying on the live Orbit bot, which is about to be retired.
@tank-royale-rumble-moderator

Copy link
Copy Markdown
Contributor

@robocode-dev/rumble-moderators Moderation needs your decision for 8897efa5c61a: Non-bot or protected file changed: GOVERNANCE.md

The required check stays pending. After reviewing, use /moderation approve <reason> or request changes.

@flemming-n-larsen
flemming-n-larsen merged commit 64269d2 into main Nov 15, 2026
3 of 4 checks passed
@flemming-n-larsen
flemming-n-larsen deleted the retire-removed-bots branch November 15, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant