Record skipped-turn telemetry in compatibility runs - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements CH-018 in the
G-001parity campaign (P-001/M-006): opt-in capture of skipped-turn callbacks received by bridge bots during compatibility runs.What this change provides
--capture-skipped-turnsis enabled, the bridge records distinct(bot ID, round, turn)callback tuples, including warm-up turns, and the harness persists them with the compatibility-run observation.captured(including a verified empty list),disabled,unavailable, andincomplete. Disabled capture removes an inherited telemetry JVM property so it cannot silently enable recording.robocode.*API and read-only rumble jars are unchanged.Evidence
python -m unittest test_parity_registry: 42 tests pass.:robocode-api:testpasses, andclue validate --forbid-changespasses (68 artifacts).SkippedTurnReportedcallback line; per-bot completion counts matched.JAVA_TOOL_OPTIONS=-Drobocode.bridge.skippedTurnTelemetry=truedid not enable recording when capture was disabled.capturedwith zero events despite having two runner score groups, confirming completion is checked against staged bots.576912114f1d66ffcc96068b9e217a3cbff9d725.Acceptance limits and remaining work
@draft, and M-148 and M-006 remaintodo. The reviewer verdict isverifies-something-adjacent: AN-016 records relevant local integration runs, but Python is not yet an accepted evidence carrier and the complete HARN-008 integration scenario is not resolved.