Now supports network NAME rather than just network TYPE#2
Now supports network NAME rather than just network TYPE#2mkoistinen wants to merge 4 commits intorobertklep:masterfrom mkoistinen:master
Conversation
…users with multiple 'Ethernet' ports Previous, this code would grab the network TYPE (e.g., 'Ethernet') rather than the network NAME (e.g., 'Built-in Ethernet'). This creates issues for people with multiple interfaces of the same type. Signed-off-by: Martin Koistinen <mkoistinen@gmail.com>
…y, the best thing would be to support both. Coming soon? Signed-off-by: Martin Koistinen <mkoistinen@gmail.com>
Signed-off-by: Martin Koistinen <mkoistinen@gmail.com>
|
Oops, actually, I only meant to create a pull request for ONE commit 6f4dc33. The others probably aren't generally useful yet. |
Signed-off-by: Martin Koistinen <mkoistinen@gmail.com>
|
I created a new branch |
|
No need to re-issue, I've implemented the changes manually in the new branch. Go and check it out, it seems to work okay now for all types of proxy. |
|
Hi Robert, great work. Unfortunately, for exactly the same reasons, it still didn't work on my system. It is clear that your system is different than mine, so it is probably hard for you to test my configuration, but I think I've updated the code correctly to work universally in my pull request (appears as a different item in the issue list). Please test and let me know! Thanks again for your help on this and I hope all this work you did (with a tiny bit of my help) helps others too. |
2 participants
Hi, one of the issues I had in making this work on my system (which has multiple Ethernet interfaces), is that the code was using the network TYPE for calls to /usr/sbin/networksetup. This is just luck that it was working at all, really, as this tool appears to require the network name. These two simple changes makes it work. =)