Skip to content

chore(rivetkit): regen stale BARE codecs for inspector v2-v4 and client-protocol v3-v4#5370

Open
abcxff wants to merge 3 commits into
mainfrom
stack/chore-rivetkit-regen-stale-bare-codecs-for-inspector-v2-v4-and-client-protocol-v3-v4-zowzzmkk
Open

chore(rivetkit): regen stale BARE codecs for inspector v2-v4 and client-protocol v3-v4#5370
abcxff wants to merge 3 commits into
mainfrom
stack/chore-rivetkit-regen-stale-bare-codecs-for-inspector-v2-v4-and-client-protocol-v3-v4-zowzzmkk

Conversation

@abcxff

@abcxff abcxff commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@abcxff

abcxff commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Stack for rivet-dev/rivet

Get stack: forklift get 5370
Push local edits: forklift submit
Merge when ready: forklift merge 5370

change zowzzmkk

@claude

claude Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Review

This is a straightforward, correct fix. Verified the following:

What's actually happening: client-protocol-versioned.ts and the inspector modules (inspector/mod.ts, inspector/client.browser.ts, workflow/inspector.ts) already import v3/v4 of the client-protocol codec and v2/v3/v4 of the inspector codec, but those generated .ts files were never committed (only client-protocol/v2.ts and inspector/v1.ts existed previously). That means the TS build was broken (unresolvable imports) until these files are checked in — this PR fixes a real regression, not just cosmetic churn.

Correctness checks performed:

  • All 6 new files carry the // @generated - post-processed by build.rs marker, have the @bare-ts/lib@rivetkit/bare-ts import rewritten, and have exactly one injected assert shim function (per build.rs's post_process_generated_ts) — no signs of hand-editing or a partial/broken regen.
  • The .bare schema directories (rivetkit-rust/packages/client-protocol/schemas/ and rivetkit-rust/packages/inspector-protocol/schemas/) already contain v1v4 for both protocols, so this change is catching up committed output to schemas that already existed — no schema changes are bundled in.
  • Spot-checked that the generated v4.ts client-protocol codec actually contains actor: ActorSpecifier | null on the relevant message, matching the hand-written v3ToV4/v4ToV3 converters in client-protocol-versioned.ts that add/strip that field.
  • Confirmed HttpQueueSendRequest/HttpQueueSendResponse encode/decode functions exist in both v3 and v4, matching the version-gated switch in client-protocol-versioned.ts (which only supports those types from v3+).

Suggestion (non-blocking): nothing currently in CI regenerates and diffs these codecs, which is presumably how v3/v4 went missing in the first place. Consider a CI step that runs the client-protocol/inspector-protocol build.rs codegen and fails on git diff against the checked-in generated/ output, so this class of drift is caught automatically next time rather than surfacing as a broken build.

No concerns with code quality, security, or performance — this is pure generated output with no hand-written logic to review, and no test changes are expected since there's no independent behavior being introduced (the schemas were already there; only the checked-in codec artifacts were missing).

@abcxff abcxff force-pushed the stack/fix-frontend-render-version_check-workflow-entries-with-icon-and-summary-oprtsksx branch from b9680eb to 1ed09c7 Compare July 4, 2026 03:31
Base automatically changed from stack/fix-frontend-render-version_check-workflow-entries-with-icon-and-summary-oprtsksx to main July 4, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant