fix: add runner metadata version handling to release script#4371
fix: add runner metadata version handling to release script#4371NathanFlurry merged 1 commit intomainfrom
Conversation
|
🚅 Deployed to the rivet-pr-4371 environment in rivet-frontend
|
PR ReviewOverall this is a solid bug fix. A few things to call out. Path resolution fix - The original code passed relative glob paths directly to fs.readFile/fs.writeFile without joining with opts.root, meaning file reads/writes would resolve relative to the process CWD rather than the repo root. The fix is correct. Regex lastIndex reset - Using .test() then .replace() on a stateful global regex without resetting lastIndex is a known footgun. The double-reset pattern is correct. path import renamed to pathModule - The loop variable shadowed the imported path module. The rename eliminates the ambiguity cleanly. Potential Issue: Regex Does Not Match Wildcard Versions - Per CLAUDE.md, examples should use Minor Nit - The outer CLAUDE.md Addition - The new development warning is useful and well-placed. |
Summary
Update the release script to handle RivetKit version updates in example package.json files. This ensures that version bumps are consistently applied across the repository, preventing stale versions in examples.
Changes
@rivetkit/*andrivetkitdependencies inexamples/**/package.jsonpathimport topathModulelastIndexbefore test/replace operations to prevent state-related bugsType of change
Testing
The changes have been reviewed against the codebase to ensure compatibility with the existing release workflow.