Conversation
|
🚅 Deployed to the rivet-pr-4200 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: chore: multiplayer cookbookThis PR adds two categories of content: (1) game example specs and agent notes under Overall the specs are well-structured and demonstrate good RivetKit actor patterns. A few issues worth addressing: Security
The spec uses a
These two statements directly contradict each other. The Either:
The AI design section lists input constraints (bounded message length, rate limits) but doesn't mention prompt injection. Players can craft messages designed to override the system prompt or make NPCs behave unexpectedly. The spec should include at least a note about sanitizing or constraining the player message before passing it to the model, and treating all player input as untrusted. InconsistenciesMissing 10 commands are added under
MMO chunked world — vague block type enum The Minor IssuesFPS spec — formatting bug In The line Command/skill content duplication The Positive Notes
|
b85f6b0 to
fb17656
Compare
e63c514 to
2055b0e
Compare
2759213 to
0b81d99
Compare
bb8536a to
b9aca01
Compare
0b81d99 to
55a92b7
Compare
55a92b7 to
beb88be
Compare
345a3a6 to
4214c51
Compare
05641ac to
36d8116
Compare
4214c51 to
bf27e5e
Compare
bf27e5e to
d25039e
Compare
36d8116 to
6a2b467
Compare
bf27e5e to
99744bc
Compare
8b03cc7 to
16a20a8
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: