test(rivetkit): update stale native integration fixture - #5644
Closed
eersnington wants to merge 1 commit into
Closed
Conversation
Author
eersnington
deleted the
stack/test-rivetkit-update-stale-native-integration-fixture-mprpqxqy
branch
September 3, 2026 19:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The native integration test (
tests/napi-runtime-integration.test.ts) has been failing on main. The code it tests is fine; the test's fixture app went stale.The fixture actor requires a
userIdwhen you connect, and the test never sent one, so the very first action was rejected. A few smaller things drifted too: the olddb.executeargument shape, an extra decode on kv values that are already strings, no clean shutdown on SIGINT, and the untyped error group isrivetkitnow instead ofcore.This updates the test and fixture to today's API. Test-only, two files, no runtime code.
Related: #5643. The test needs that fix as well to pass; without it, it fails earlier at the Engine health check.
Type of change
How Has This Been Tested?
Checklist: