Skip to content

test(rivetkit): remove stale http stream coverage - #5642

Closed
eersnington wants to merge 1 commit into
rivet-dev:mainfrom
eersnington:stack/test-rivetkit-napi-remove-stale-http-stream-coverage-woznvllk
Closed

test(rivetkit): remove stale http stream coverage#5642
eersnington wants to merge 1 commit into
rivet-dev:mainfrom
eersnington:stack/test-rivetkit-napi-remove-stale-http-stream-coverage-woznvllk

Conversation

@eersnington

Copy link
Copy Markdown

Description

  • cargo test -p rivetkit-napi does not compile on main. The crate's test module still has cancelling_http_request_body_drops_core_receiver, which imports HttpRequestBodyStream from rivetkit_core and from the NAPI wrapper.
  • Both types were removed when SSE streaming was cleaned up (e534b6e) and the dangling core re-export was dropped (d44805d). The test outlived what it tested.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

# Before, on main:

$ cargo test -p rivetkit-napi --no-run
error[E0432]: unresolved import `rivetkit_core::HttpRequestBodyStream`
error[E0432]: unresolved import `super::HttpRequestBodyStream`
error: could not compile `rivetkit-napi` (lib test) due to 2 previous errors

# After:

$ cargo test -p rivetkit-napi --no-run
    Finished `test` profile [unoptimized + debuginfo] target(s) in 3.73s

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@eersnington
eersnington force-pushed the stack/test-rivetkit-napi-remove-stale-http-stream-coverage-woznvllk branch from 1b87b97 to 8cd08a9 Compare September 2, 2026 21:17
@eersnington

Copy link
Copy Markdown
Author

closing since a fix is merged 8b57037

@eersnington eersnington closed this Sep 3, 2026
@eersnington
eersnington deleted the stack/test-rivetkit-napi-remove-stale-http-stream-coverage-woznvllk branch September 3, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant