test(rivetkit): remove stale http stream coverage - #5642
Closed
eersnington wants to merge 1 commit into
Closed
Conversation
eersnington
force-pushed
the
stack/test-rivetkit-napi-remove-stale-http-stream-coverage-woznvllk
branch
from
September 2, 2026 21:17
1b87b97 to
8cd08a9
Compare
Author
|
closing since a fix is merged 8b57037 |
eersnington
deleted the
stack/test-rivetkit-napi-remove-stale-http-stream-coverage-woznvllk
branch
September 3, 2026 19:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cargo test -p rivetkit-napidoes not compile on main. The crate's test module still hascancelling_http_request_body_drops_core_receiver, which importsHttpRequestBodyStreamfromrivetkit_coreand from the NAPI wrapper.Type of change
How Has This Been Tested?
Checklist: