Move API framework to its own repo for reuse #307
Conversation
brandur
force-pushed
the
brandur-riverapiframe
branch
from
47af12b to
69b5424
Compare
| module riverqueue.com/riverui | ||
|
|
||
| go 1.22.0 | ||
| go 1.23.0 |
There was a problem hiding this comment.
Ugh, I tried not to change this, but the new repo really wanted to be Go 1.23 (and run of go mod tidy would change it to such), and when I brought that in here, of course it'd take this project to 1.23 as well.
Probably okay though since we don't really need to make as much an effort to support very old Go versions for this project, and currently only 1.23 and 1.24 are supported.
There was a problem hiding this comment.
Yeah I think it's fine, latest 2 Go versions is a reasonable and common stance.
| module riverqueue.com/riverui | ||
|
|
||
| go 1.22.0 | ||
| go 1.23.0 |
There was a problem hiding this comment.
Yeah I think it's fine, latest 2 Go versions is a reasonable and common stance.
| runs-on: ubuntu-latest | ||
| env: | ||
| GOLANGCI_LINT_VERSION: v1.63.4 | ||
| GOLANGCI_LINT_VERSION: v1.64.6 |
There was a problem hiding this comment.
We were on 1.64.4 elsewhere so we probably need to bump everywhere.
There was a problem hiding this comment.
Luckily I don't think the new versions make that big of a difference (at least between 1.63 and 1.64). The main thing for some of them recently was getting in Go 1.24 support. But yeah, we should start rolling all the versions forward as we get to them.
Here, move the API framework, which is currently duplicated in two projects, over to its own repository so that we can reuse it between them. It's new home will be `riverapiframe` [1]. [1] riverqueue/apiframe#1
brandur
force-pushed
the
brandur-riverapiframe
branch
from
69b5424 to
460a28f
Compare
|
Thanks! |
Here, move the API framework, which is currently duplicated in two
projects, over to its own repository so that we can reuse it between
them. It's new home will be
riverapiframe[1].[1] riverqueue/apiframe#1