Repository navigation
Fix for notifier retrying without backoff when context reaches deadline - #1495
Merged
Merged
Conversation
Fixes #1493. A notifier connecting after its context deadline was reached would enter a hot loop, retry forever, and flood logs while doing so. Fix is to make sure there's a check on `ctx.Err()`.
brandur
force-pushed
the
brandur-notifier-flood-fix
branch
from
October 10, 2026 19:46
ef8452e to
3570664
Compare
nooby6
reviewed
Oct 12, 2026
nooby6
left a comment
nooby6
left a comment
There was a problem hiding this comment.
I reviewed the retry-loop change and its added tests. The important distinction is checking the service context (ctx.Err()) rather than classifying the returned operation error: a listener operation can return a wrapped cancellation/deadline while the service context is still live, and that should not stop the notifier. The ListenerDeadlineExceeded case exercises that boundary, while the service-context cancellation/deadline cases cover shutdown. I don't see a blocking correctness issue in this diff.
bgentry
approved these changes
Oct 12, 2026
Contributor
Author
|
thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1493. A notifier connecting after its context deadline was
reached would enter a hot loop, retry forever, and flood logs while
doing so. Fix is to make sure there's a check on
ctx.Err().