make raw payload available to ExtractRaw #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
approved these changes
Mar 15, 2025
Contributor
brandur
left a comment
brandur
left a comment
There was a problem hiding this comment.
Looks like some linter issues with tag alignment, but looks good.
Capture the request payload and reset the http request body so that `ExtractRaw` can still read the original payload if desired. This is useful in situations like validating a request payload against a signature.
bgentry
force-pushed
the
bg-make-req-payload-available-to-extractraw
branch
from
ed7f024 to
422cfb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture the request payload and reset the http request body so that
ExtractRawcan still read the original payload if desired. This is useful in situations like validating a request payload against a signature.To make this work without adding another test endpoint, I switched the
GETandPOSTendpoints so the former is the one that implementsExtractRawwhere we can test both a path param and the request body at the same time. I didn't want to have a situation where all of the endpoints implementExtractRawand we weren't testing the default path.