Skip to content

data(oss): openapi-sampler #223 is merged - #4

Merged
rishitank merged 3 commits into
mainfrom
data/openapi-sampler-223-merged
Oct 31, 2026
Merged

rishitank merged 3 commits into
mainfrom
data/openapi-sampler-223-merged

Conversation

@rishitank

@rishitank rishitank commented Oct 31, 2026 •

Copy link
Copy Markdown
Owner

What

The Redoc entry said my XML fixes to openapi-sampler "await review". Redocly/openapi-sampler#223 was approved by makare11a on 26 Oct 2026 and squash-merged into main on 28 Oct (dc4e5c0).

  • data/open-source.json: the text now says they "were merged after review". The #223 evidence pins merged: true, base: main (was state: open) and adds makare11a's approval comment.
  • data/open-source-ledger.json: Redocly/openapi-sampler#223 → state: merged, updatedAt: 2026-10-28T15:11:58Z (GitHub's current value).
  • README.md: regenerated by scripts/oss/render-readme.mjs.

Why now

The weekly job would normally propose this. Its 26 Oct run failed at the curate step: the token was present, but the Claude run returned an error after about 0.5 s, cause not yet diagnosed. And from the next run its claim check would fail, because #223 is no longer open.

Not claimed

No release is named: openapi-sampler's latest release is still v1.7.9 (21 Oct), and the release PR (#231) is open. "Merged after review" rests only on the merged PR and the approval comment.

Checks

  • node --test tests/*.test.mjs: 44 pass
  • node scripts/oss/validate.mjs: OK, 14 entries, ledger 70 items (21 included)
  • render-readme --check: in step
  • verify-claims: run by this PR's ci-gate against the live API (it can't reach the API from my session).

The branch has two commits: the second restores one ledger reason (webpack/css-loader#883) that the first copied wrongly. Squash on merge; the net diff is 3 files, +6/−5.

🤖 Generated with Claude Code

https://claude.ai/code/session_01117LuacuBxMJUn1wJkfdyL

rishitank and others added 2 commits October 31, 2026 22:15
Redocly merged the XML fixes on 28 Oct 2026 after makare11a's approval, so
the Redoc entry no longer says they await review. Evidence now pins #223
as merged into main plus the approval comment, and the ledger records the
new state and updatedAt, so the weekly re-check stays green.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01117LuacuBxMJUn1wJkfdyL
The previous commit copied #882's reason onto #883 by mistake; this puts
back "Resolved by a change to my own config." so the only ledger change in
this PR is openapi-sampler #223.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01117LuacuBxMJUn1wJkfdyL
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 501d2c75-a8bd-4abb-883a-989d5ec2b694
Commits

Reviewing files that changed from the base of the PR and between e073ddc and c5fe341.

Files selected for processing: 2
  • README.md
  • data/open-source.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Additional comments: 2
data/open-source.json: 1

10-10: LGTM!

Also applies to: 14-14, 17-18

README.md: 1

55-55: LGTM!

Summary

Summary by CodeRabbit

  • Documentation
    • Updated the Redoc entry to reflect that the XML fixes to openapi-sampler were merged after review.
    • Updated the open-source project records to show the pull request as merged, with its latest update date and supporting approval information.

The Redoc entry now reports that the openapi-sampler XML fixes were merged after review. The supporting evidence records PR 223 as merged on main, and the ledger records its updated state and timestamp.

Changes: Redoc Status Update

Layer / File(s) Summary
Update merge evidence and status display
data/open-source.json, data/open-source-ledger.json, README.md
The evidence records PR 223 as merged on main and adds supporting comments. The ledger state and timestamp are updated. The Redoc text now reports the merge.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

  • rishitank/rishitank#2: It records the same openapi-sampler#223 entry as awaiting review. This change updates that entry to merged.
  • rishitank/rishitank#3: It establishes the data records and README generation flow that this change updates.
Merge Risk: Minimal · up to c5fe3

The status and supporting evidence updates are ready to merge with no identified blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the main change: recording that openapi-sampler issue #223 was merged.
Description check Passed The description is directly related to the changeset and explains the data updates, evidence, generated README change, and validation checks.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Apprentice, the status now shines merged.
Evidence records the path to main.
The ledger marks the time and state.
Redoc speaks with one clear voice.
The rebel scum of stale claims retreat.
The Dark Side keeps the record straight.

@rishitank

Copy link
Copy Markdown
Owner Author

Independent review (Claude, separate session context)

No blocking findings. Every claim in the changed entry was checked against GitHub:

  • #223: merged into main (28 Oct, 09:44:53Z) after makare11a's APPROVED review on 26 Oct. That review followed a CHANGES_REQUESTED review on 19 Oct, so "merged after review" is no stronger than the thread.
  • The approval quote: "thank you for your contribution. Approved" is an issue comment by makare11a, exact and case-sensitive. That is where verify-claims looks for comment evidence.
  • Evidence format: pr evidence with both merged and base is allowed by scripts/oss/lib.mjs.
  • Ledger: merged is a valid state, and updatedAt matches GitHub's updated_at (2026-10-28T15:11:58Z) on both the pulls and issues endpoints.
  • Redoc #2869: still merged and unreleased (latest is redoc@3.0.1, 14 Oct), so "merged for the next release" still holds.
  • Diff: the branch changes only README.md and the two data files (+6/−5). Commit e073ddc fully reverts the css-loader#883 reason that aac8709 overwrote.
  • Checks: node --test 44/44, validate OK, render-readme --check in step. ci-gate's verify-claims reported 81/81.

Findings

  1. Should-fix, now fixed: the description said the weekly curate step fails because its secrets aren't set. The 26 Oct job log shows CLAUDE_CODE_OAUTH_TOKEN was set; the Claude run returned is_error: true after 457 ms. The description is corrected, and the cause is a follow-up.
  2. Nit: openapi-sampler's changeset release notes cite the commit (dc4e5c0), not #223. A future release-mentions watch should use contains: "dc4e5c0". The existing Redoc watch on #2869 may never fire for the same reason (3.0.1's note cites fc5ac9a).
  3. Nit, fixed: "6 lines" changed to "+6/−5".

Merge after CodeRabbit finishes.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Oct 31, 2026
Two developers on Redocly/redoc#2347 report the same issue (LeWolOnline:
"I'm experiencing the same issue it solves"; ndmitrys: "Oh, I'm experiencing
the same issue"), and a third asks for an update. The 15 Oct wording
"another developer" undercounted; ndmitrys's comment is added as evidence.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01117LuacuBxMJUn1wJkfdyL
@rishitank

Copy link
Copy Markdown
Owner Author

One more fix, in c5fe341: the independent review of the portfolio (rishitank-portfolio#49) caught that "later backed by another developer" undercounts.

On Redocly/redoc#2347:

  • LeWolOnline: "I'm experiencing the same issue it solves"
  • ndmitrys: "Oh, I'm experiencing the same issue"
  • kamukondiwa also asks for an update.

So the text now says "other developers", and ndmitrys's comment is added as evidence. The 15 Oct review that changed it to "one other developer" was wrong.

Local checks: node --test 44/44, validate OK, render-readme --check in step. Every pushed blob matches. Net diff against main: 3 files, +7/−5.

@rishitank

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@rishitank
rishitank merged commit da71d22 into main Oct 31, 2026
2 checks passed
@rishitank
rishitank deleted the data/openapi-sampler-223-merged branch October 31, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant