feat(pdf): add timeout guard for PDF generation (#762)#882
Open
CyberXpert607 wants to merge 2 commits into
Open
feat(pdf): add timeout guard for PDF generation (#762)#882CyberXpert607 wants to merge 2 commits into
CyberXpert607 wants to merge 2 commits into
Conversation
- Add withTimeout utility with proper timer cleanup - Implement PDF generation service with Puppeteer - Add 30s timeout to certificate download route - Add 30s timeout to generic PDF generation route - Return HTTP 504 on timeout with retry message - Add integration test for timeout scenario - Set page.setDefaultTimeout(25000) - Add PDF_TIMEOUT_MS environment variable - Remove any types from modified files
|
@CyberXpert607 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Great job so far There’s just one blocker — workflow failing. Could you take a look and resolve it? Happy to review again once that’s done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #762: Adds timeout guard for PDF generation to prevent hanging connections.
Changes Made
1. Timeout Utility (
src/lib/timeout.ts)withTimeoutfunction usingPromise.race2. PDF Generation Service (
src/services/pdf-generation.ts)page.setDefaultTimeout(25000)finallyblockanytype with properCertificateinterface3. Certificate Download Route (
src/app/api/certificates/[id]/download/route.ts)unknownerror handling4. Generic PDF Generation Route (
src/app/api/generate-pdf/route.ts)unknownerror handling5. Integration Test
6. Environment Variable
PDF_TIMEOUT_MS=30000addedScope Note
Only files directly related to #762 were modified. No other files were touched.
Related Issue
Closes #762
Checklist