feat: Connect certificate service to progress tracking system (#761)#881
Open
Benedict315 wants to merge 3 commits into
Open
feat: Connect certificate service to progress tracking system (#761)#881Benedict315 wants to merge 3 commits into
Benedict315 wants to merge 3 commits into
Conversation
…ode#761) - Add CourseProgressSchema for tracking individual course completion - Create certificate-service.ts with validateCourseCompletion function - Add /api/certificates/generate endpoint with 403 for incomplete courses - Add comprehensive tests for certificate validation - Add database migration for user_progress table - Update API types to export CourseProgress Certificate generation now validates progress >= 100% before issuing, preventing certificates for incomplete courses.
|
@Benedict315 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…rror - Update CourseProgressSchema to use .optional() instead of .nullable() - This changes the type from string | null to string | undefined - Fixes CI type-check error on line 53 of certificate-service.ts
Contributor
|
Great job so far There’s just one blocker — workflow failing. Could you take a look and resolve it? Happy to review again once that’s done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certificate generation now validates progress >= 100% before issuing, preventing certificates for incomplete courses.
Description
Brief description of changes
Related Issue
Closes #
Type of Change
Checklist
closes [Enhancement] Certificate service has a hardcoded completion check — real progress tracking not connected #761