fix: Enable TLS certificate validation in production#838
Merged
RUKAYAT-CODER merged 3 commits intoJul 2, 2026
Merged
Conversation
- Set rejectUnauthorized: true in production SSL config - Add DB_SSL_CA environment variable for CA certificate path - Validate DB_SSL_CA is provided on module load in production - Development continues to allow unverified certificates - Document required environment variables in .env.example Fixes: Prevents man-in-the-middle attacks by enforcing TLS certificate verification in production database connections.
|
@MooreTheAnalyst Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Great job so far There’s just one blocker — merge conflict. Could you take a look and resolve it? Happy to review again once that’s done. |
Contributor
Author
|
Yes. Sure. Will take a look and resolve it now. |
…ironment variables
Contributor
Author
|
I have resolved it. Should be ready to merge :) |
Contributor
|
Thank you for contributing to the project. |
Contributor
Author
|
It is a pleasure to :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the PostgreSQL TLS certificate validation vulnerability (#709):
src/lib/db/pool.ts - Set
rejectUnauthorized: truein production, addedDB_SSL_CAenvironment variable for CA certificate path, and added startup validation to ensure it's provided in production..env.example - Documented the new
DB_SSL_CAvariable with usage examples.Branch & Commit - Created
fix/709-postgresql-tls-certificate-validationbranch, committed changes with clear message, and pushed to origin. No type errors detected. Ready for PR.Closes #709