fix: support diacritic-insensitive search indexing closes (#629)#749
Merged
Conversation
|
@itzabdoull Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #629
Description
This PR resolves issue #629 where search queries containing or targeting courses containing Unicode diacritics (accents/umlauts/etc.) were not matching. For example, searching for "cafe" now successfully returns courses titled "Café Communication", and "resume" finds "Résumé Writing".
Key Changes
New Utility Function: Added
normalizeText
in src/utils/stringUtils.ts to convert text into Unicode NFD form and strip out all diacritical marks via regex (normalize('NFD').replace(/[\u0300-\u036f]/g, '')).
Normalized Indexing (Index-Build Time): Integrated normalizeText into the course indexing pipeline in
searchIndex.ts
for:
Course title tokens and individual word suggestions.
Course category tokens.
Instructor name tokens.
Cap-sliced course description tokens.
Note: Original display text in documents is preserved unchanged so the user interface renders unmodified characters (e.g., 'Café').
Normalized Query Matching (Query Time): Normalized the user query string in the search function before tokenization and prefix matching.
Unit Tests: Added
searchIndex.test.ts
covering matches for:
'Café' → 'cafe'
'Résumé' → 'resume'
'München' → 'munchen'
'Ñoño' → 'nono'
Verification
Run npx jest tests/services/searchIndex.test.ts (All 4 unit tests pass)
Run npx jest tests/services/searchIndex.perf.test.ts (Validates execution meets the 50ms index query budget)